Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node
{
"name": "Node.js",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-22-bookworm"

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "yarn install",

// Configure tool-specific properties.
// "customizations": {},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
1 change: 0 additions & 1 deletion .eslintignore

This file was deleted.

6 changes: 0 additions & 6 deletions .eslintrc

This file was deleted.

38 changes: 14 additions & 24 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,60 +3,50 @@ on:
pull_request:
push:
branches:
- master
- main
env:
CI: true

jobs:
prettier:
name: Format code
runs-on: ubuntu-latest
if: ${{ github.event_name == 'push' }}

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Prettier
uses: gulpjs/prettier_action@v3.0
with:
commit_message: 'chore: Run prettier'
prettier_options: '--write .'

test:
name: Tests for Node ${{ matrix.node }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node: [10, 12, 14, 16]
node: [22, 24, 26]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
- name: Clone repository
uses: actions/checkout@v2
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Set Node.js version
uses: actions/setup-node@v2
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: ${{ matrix.node }}

- run: node --version
- run: npm --version
- name: Check node version
run: node --version

- name: Check npm version
run: npm --version

- name: Install npm dependencies
run: npm install
run: npm ci

- name: Run lint
run: npm run lint

- name: Run tests
run: npm test

- name: Check format
run: npm run format-check

- name: Coveralls
uses: coverallsapp/github-action@v1.1.2
uses: coverallsapp/github-action@8d6379e14d29928660c4ba802d8e85393440b329 # v2.3.8
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: ${{matrix.os}}-node-${{ matrix.node }}
Expand All @@ -69,7 +59,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: coverallsapp/github-action@v1.1.2
uses: coverallsapp/github-action@8d6379e14d29928660c4ba802d8e85393440b329 # v2.3.8
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
8 changes: 5 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@ name: release
on:
push:
branches:
- master
- main

jobs:
release-please:
runs-on: ubuntu-latest
permissions:
contents: write
issues: write
pull-requests: write
steps:
- uses: GoogleCloudPlatform/release-please-action@v2
- uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # v5.0.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: node
package-name: release-please-action
1 change: 0 additions & 1 deletion .npmrc

This file was deleted.

2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2017-2018, 2020, 2022-2023 Blaine Bublitz <blaine.bublitz@gmail.com> and Eric Schoffstall <yo@contra.io>
Copyright (c) 2017-2018, 2020, 2022-2023, 2026 Blaine Bublitz <blaine.bublitz@gmail.com> and Eric Schoffstall <yo@contra.io>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
26 changes: 18 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ Watch globs and execute a function upon change, with intelligent defaults for de
## Usage

```js
var watch = require('glob-watcher');
var watch = require("glob-watcher");

watch(['./*.js', '!./something.js'], function (done) {
watch(["./*.js", "!./something.js"], function (done) {
// This function will be called each time a globbed file is changed
// but is debounced with a 200ms delay (default) and queues subsequent calls

Expand All @@ -31,18 +31,18 @@ watch(['./*.js', '!./something.js'], function (done) {
});

// Raw chokidar instance
var watcher = watch(['./*.js', '!./something.js']);
var watcher = watch(["./*.js", "!./something.js"]);

// Listen for the 'change' event to get `path`/`stat`
// No async completion available because this is the raw chokidar instance
watcher.on('change', function (path, stat) {
watcher.on("change", function (path, stat) {
// `path` is the path of the changed file
// `stat` is an `fs.Stat` object (not always available)
});

// Listen for other events
// No async completion available because this is the raw chokidar instance
watcher.on('add', function (path, stat) {
watcher.on("add", function (path, stat) {
// `path` is the path of the changed file
// `stat` is an `fs.Stat` object (not always available)
});
Expand Down Expand Up @@ -111,6 +111,16 @@ Default: `[ 'add', 'change', 'unlink' ]`

Options are passed directly to [chokidar][chokidar].

## Strict No LLM / No AI Policy

No LLMs for issues.

No LLMs for patches / pull requests.

No LLMs for comments on the bug tracker, including translation.

English is encouraged, but not required. You are welcome to post in your native language and rely on others to have their own translation tools of choice to interpret your words.

## License

MIT
Expand All @@ -120,11 +130,11 @@ MIT
[npm-url]: https://npmjs.com/package/glob-watcher
[npm-image]: https://img.shields.io/npm/v/glob-watcher.svg?style=flat-square

[ci-url]: https://github.com/gulpjs/glob-watcher/actions?query=workflow:dev
[ci-image]: https://img.shields.io/github/actions/workflow/status/gulpjs/glob-watcher/dev.yml?branch=master&style=flat-square
[ci-url]: https://github.com/gulpjs/glob-watcher/actions/workflows/dev.yml
[ci-image]: https://img.shields.io/github/actions/workflow/status/gulpjs/glob-watcher/dev.yml?style=flat-square

[coveralls-url]: https://coveralls.io/r/gulpjs/glob-watcher
[coveralls-image]: https://img.shields.io/coveralls/gulpjs/glob-watcher/master.svg?style=flat-square
[coveralls-image]: https://img.shields.io/coveralls/gulpjs/glob-watcher/main.svg?style=flat-square
Comment thread
phated marked this conversation as resolved.
Resolved
<!-- prettier-ignore-end -->

<!-- prettier-ignore-start -->
Expand Down
3 changes: 3 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
var gulpConfig = require("eslint-config-gulp");

module.exports = [...gulpConfig.default];
16 changes: 8 additions & 8 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';
"use strict";

var chokidar = require('chokidar');
var asyncDone = require('async-done');
var normalizeArgs = require('./lib/normalize-args');
var debounce = require('./lib/debounce');
var chokidar = require("chokidar");
var asyncDone = require("async-done");
var normalizeArgs = require("./lib/normalize-args");
var debounce = require("./lib/debounce");

function watch(glob, options, cb) {
return normalizeArgs(glob, options, cb, watchProc);
Expand All @@ -16,7 +16,7 @@ function watchProc(globs, options, cb) {
}

function registerWatchEvent(watcher, opts, cb) {
if (typeof cb !== 'function') {
if (typeof cb !== "function") {
return;
}

Expand All @@ -26,8 +26,8 @@ function registerWatchEvent(watcher, opts, cb) {
function runComplete(err) {
running = false;

if (err && watcher.listenerCount('error') > 0) {
watcher.emit('error', err);
if (err && watcher.listenerCount("error") > 0) {
watcher.emit("error", err);
}

// If we have a run queued, start onChange again
Expand Down
2 changes: 1 addition & 1 deletion lib/debounce.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'use strict';
"use strict";

function debounce(fn, delay) {
var timeout;
Expand Down
6 changes: 3 additions & 3 deletions lib/normalize-args.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
'use strict';
"use strict";

var defaultOpts = {
delay: 200,
events: ['add', 'change', 'unlink'],
events: ["add", "change", "unlink"],
ignored: [],
ignoreInitial: true,
queue: true,
};

function normalizeArgs(glob, options, cb, next) {
if (typeof options === 'function') {
if (typeof options === "function") {
cb = options;
options = {};
}
Expand Down
Loading
Loading