[FotoVerite]

Closes #89

This is not complete yet, there are some tests that seem to do nothing. I have kept them commented out so they are easily looked at

t.plan might not work the same as assertions so the first debounce test might need to be written

and #46 is happening again?

[FotoVerite]

So I've been able to fix most tests, I'm using a promise to await before checking runs which seems like a sane choice to deal with the assert swallowing I found wish it was a bit more elegant but it isn't cludge.

I removed t.plan(1) from the debounce test because I can't figure out the purpose of it originally and it always should have been 2 from my reading of the mocha the other test is showing a regression

// #46
it("ignoring globs also works with cwd option", function (t, done) {
watcher = watch(["fixtures/**", "!fixtures/*.js"], { cwd: "test" });

watcher.once("change", function (filepath) {
  // It should never reach here
  assert.ok(!filepath);
  done();
});

// We default `ignoreInitial` to true, so always wait for `on('ready')`
watcher.on("ready", changeFile);

setTimeout(done, 1500);

});

i'm unsure why this passed in the mocha and looks like it's related to chokidar and probably needs actual code changes and or an update to chokidar which is on 6.

[phated]

Some changes still needed and I will think about the promise usage.

[phated]

This looks like the plan was 1 and it was lost

[FotoVerite]

It calls t.plan is called twice I'm confused how it would only call one. I think mocha might work different but even with done being called the assert is still counted.

[phated]

Suggested change

	test/lcov.info
	test/lcov.info
	test/fixtures/

Fixtures are generated during test so they should be ignored

[phated]

Suggested change

	var normalizePath = require("normalize-path");
	var through = require("through2");
	var through = require("through2");
	var normalizePath = require("normalize-path");

diff nit

[FotoVerite]

why normalize over through originally? Not alphabetical?

[phated]

Interesting use of this. Let me think about it a bit.