Repository navigation
Count cloud-agent PRs and refuse truncated searches in sprint planning - #252
Merged
Merged
Conversation
fetch-team-prs.sh also returns PRs that posthog[bot] authored and assigned to the member. A shared search-prs.sh runs gh search prs at GitHub's 1000-result ceiling and exits non-zero when a search fills it. fetch-approved-prs.sh uses the same helper. Step 5 credits In Review and Approved board items to their board assignees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sprint-planning retro undercounted shipped work in two ways.
fetch-team-prs.shsearched only by author, so it missed every PR a cloud agent opened, sinceposthog[bot]is the author and the person who started the agent is the assignee. For the Oct 5 to 16 sprint it returned no PRs for a teammate who merged 9, all of them agent PRs. It also capped the search at 50 results without a warning, so a member with 77 merged PRs got 50.fetch-approved-prs.shhad the same silent cap at 100, and Step 5 of the skill credited In Review and Approved items to the PR author, which dropped agent PRs from the plan.fetch-team-prs.shnow runs a second search forapp/posthogPRs assigned to the member and merges the two results. I matched on assignee because all 436 agent PRs merged org-wide in that window were merged bytrunk-io, so the merger never names the person. A newsearch-prs.shruns both scripts' searches at GitHub's 1000-result ceiling and exits non-zero when a search fills it, sincegh search prsreports no total. Step 5 now credits In Review and Approved items to their board assignees, as the--statusflow already does. The--approvedlist still shows "by @PostHog" for agent PRs. That affects display only and is not changed here.Test plan
python3 -m pytest -qinai/skills/sprint-planning/scriptspasses (61 tests).PR_SEARCH_LIMIT=20, a real search exits 1 and reports the truncation.