fix(cli): Pi RPC parsers compatible with Zod 4 optional fields#67
Closed
heavygee wants to merge 1 commit into
Closed
fix(cli): Pi RPC parsers compatible with Zod 4 optional fields#67heavygee wants to merge 1 commit into
heavygee wants to merge 1 commit into
Conversation
asStrOrDef/asOpt* helpers now treat missing keys as undefined so get_available_models/get_commands parsing works again. safeParse success checked explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
heavygee
added
the
cold-review-clean
Owner
Author
|
Fork-stage cold review complete (cold-review-clean). Upstream PR: tiann#973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parsePiModels/parsePiCommandschecksafeParsesuccess explicitlyTest plan
bun typecheck(repo root)cd cli && bun run test src/pi/loop.test.ts— 30/30 passUpstream tracking
Upstream issue: tiann#972
Fork proof: heavygee/hapi PR #65 (merged to fork main @
2a4ae30c)Disclosure
Drafted with composer via Cursor; reviewed and tested by the human contributor.