Skip to content

chore(deps): update Rust crate demand to v2.0.1#149

Merged
joaolfp merged 1 commit into
mainfrom
chore/update-demand-crate
May 7, 2026
Merged

chore(deps): update Rust crate demand to v2.0.1#149
joaolfp merged 1 commit into
mainfrom
chore/update-demand-crate

Conversation

@joaolfp
Copy link
Copy Markdown
Contributor

@joaolfp joaolfp commented May 7, 2026

✨ Summary

  • update demand dependency from 1.8.2 to 2.0.1
  • consolidate windows-sys transitive dependencies to 0.61.2

🔧 Type of Change

  • ✨ Enhancement
  • 🐞 Bug fix
  • 🔐 Security fix
  • 💥 Breaking change
  • 🚀 New feature
  • 📦 New release
  • 📚 Documentation
  • ♻️ Refactor

Note

Medium Risk
Dependency-only change, but demand is a major-version bump and lockfile updates consolidate many Windows-related transitive crates, which could cause build/runtime differences on Windows.

Overview
Updates the demand crate from 1.8.2 to 2.0.1 in Cargo.toml.

Regenerates Cargo.lock, notably converging multiple transitive windows-sys versions onto 0.61.2 across several dependencies.

Reviewed by Cursor Bugbot for commit 1f3415a. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the demand dependency to version 2.0.1 and attempts to consolidate multiple versions of the windows-sys transitive dependency in Cargo.lock. A critical issue was identified regarding the manual modification of the lockfile; forcing semver-incompatible versions of windows-sys onto crates like rustix and os_pipe will likely lead to compilation errors and bypasses Cargo's dependency resolution. It is recommended to revert these manual changes and instead update direct dependencies to versions that natively support the newer windows-sys crate.

Comment thread Cargo.lock
checksum = "40c48f72fd53cd289104fc64099abca73db4166ad86ea0b4341abe65af83dadc"
dependencies = [
"windows-sys 0.60.2",
"windows-sys 0.61.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Manually editing Cargo.lock to force incompatible versions of transitive dependencies is a critical issue. In Rust, versions 0.45.x, 0.52.x, 0.60.x, and 0.61.x of windows-sys are considered semver-incompatible. By forcing crates like anstyle-query, colored, os_pipe, and rustix to use 0.61.2 when they were designed for older versions, you are likely to cause compilation errors due to API changes. Furthermore, Cargo.lock is an auto-generated file. Manual edits that contradict the dependency requirements of the crates in the graph will be overwritten by Cargo or cause the build to fail consistency checks. Action required: Revert the manual edits to windows-sys entries in Cargo.lock. To consolidate windows-sys versions, you must update your direct dependencies (e.g., os_pipe, rustix) to versions that have already migrated to windows-sys 0.61. If no such versions exist, you must allow the multiple versions to coexist.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🎉 All unit tests passed!

@joaolfp joaolfp merged commit c1c8b5d into main May 7, 2026
4 checks passed
@joaolfp joaolfp deleted the chore/update-demand-crate branch May 7, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant