Repository navigation
fix(credentials): fall back on native store misses - #457
Merged
Merged
Conversation
breaking synchronous callers. Restrict child environments and redact unsafe Windows credential diagnostics. Add fallback and privacy tests.
confirmed absence to fall back to .netrc without telemetry. Preserve the synchronous handler API and prioritize locked Linux matches.
heroku-johnny
approved these changes
Nov 5, 2026
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logs surfaced credential lookup errors when no matching credential existed in the native store. GUS ticket W-24157168 tracks the fix: treat confirmed misses as absent credentials and continue to .netrc, while keeping genuine store failures reportable.
WHY
A missing credential in the native OS store is expected for users who authenticate through
.netrcor another existing source. Treating that miss as a failure creates misleading monitoring events and obscures genuine credential-store problems.WHAT
.netrcfallback.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
CI should suffice
Screenshots (if applicable)
Related Issues
GUS work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002kRaVmYAK/view