Skip to content

Move RPC Shutdown source to home-assistant/app-rpc-shutdown - #4918

Merged
sairon merged 1 commit into
masterfrom
split-rpc-shutdown
Nov 2, 2026
Merged

sairon merged 1 commit into
masterfrom
split-rpc-shutdown

Conversation

@sairon

@sairon sairon commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in rpc_shutdown/.

Refs #4888

Summary by CodeRabbit

  • New Features
    • Added RPC Shutdown to the app catalog, linked to its published repository and image.
  • Chores
    • Removed the app’s local build and runtime configuration. The catalog entry now references the published image instead. This changes how the app is packaged; the update does not describe any change to its shutdown options or behavior.

Keep only the app index metadata in rpc_shutdown/.

Refs #4888
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ebd5680-794a-4c40-bc52-87cbd1495610
Commits

Reviewing files that changed from the base of the PR and between b086220 and 6b0bca8.

Files selected for processing: 5
  • .apps.yml
  • .yamllint
  • rpc_shutdown/Dockerfile
  • rpc_shutdown/build.yaml
  • rpc_shutdown/data/run.sh
Files with no reviewable changes: 3
  • rpc_shutdown/build.yaml
  • rpc_shutdown/data/run.sh
  • rpc_shutdown/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The app registry now points rpc_shutdown to an external repository and image. The local build configuration, Dockerfile, and shutdown script are removed. The yamllint ignore list includes /rpc_shutdown/config.yaml.

Changes: RPC Shutdown app registration

Layer / File(s) Summary
Register app and remove local implementation
.apps.yml, .yamllint, rpc_shutdown/build.yaml, rpc_shutdown/Dockerfile, rpc_shutdown/data/run.sh
The app registry maps rpc_shutdown to home-assistant/app-rpc-shutdown. The yamllint ignore list includes /rpc_shutdown/config.yaml. The local build configuration, Dockerfile, and runtime script are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: pvizeli, stefanroelofs

Merge Risk: Minimal · up to 6b0bc

The app now uses the intended external source and image, with no concrete merge-blocking issue established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: the RPC Shutdown source is moved to the home-assistant/app-rpc-shutdown repository. The summary confirms that the rpc_shutdown/ directory is reduced to app index meta…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the RPC Shutdown source is moved to the home-assistant/app-rpc-shutdown repository. The summary confirms that the rpc_shutdown/ directory is reduced to app index metadata (the .apps.yml entry and the .yamllint ignore entry), and that the Dockerfile, build.yaml, and data/run.sh are deleted. The title matches the objectives and the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sairon
sairon merged commit 020dcc6 into master Nov 2, 2026
7 checks passed
@sairon
sairon deleted the split-rpc-shutdown branch November 2, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants