Repository navigation
Move RPC Shutdown source to home-assistant/app-rpc-shutdown - #4918
Conversation
Keep only the app index metadata in rpc_shutdown/. Refs #4888
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Register app and remove local implementation .apps.yml, .yamllint, rpc_shutdown/build.yaml, rpc_shutdown/Dockerfile, rpc_shutdown/data/run.sh |
The app registry maps rpc_shutdown to home-assistant/app-rpc-shutdown. The yamllint ignore list includes /rpc_shutdown/config.yaml. The local build configuration, Dockerfile, and runtime script are removed. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Suggested reviewers: pvizeli, stefanroelofs
Merge Risk: 
Minimal · up to 6b0bc
-
The app now uses the intended external source and image, with no concrete merge-blocking issue established.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title states the main change: the RPC Shutdown source is moved to the home-assistant/app-rpc-shutdown repository. The summary confirms that the rpc_shutdown/ directory is reduced to app index metadata (the .apps.yml entry and the .yamllint ignore entry), and that the Dockerfile, build.yaml, and data/run.sh are deleted. The title matches the objectives and the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Keep only the app index metadata in rpc_shutdown/.
Refs #4888
Summary by CodeRabbit