Skip to content

Move Whisper source to home-assistant/app-whisper - #4928

Merged
sairon merged 1 commit into
masterfrom
split-whisper
Nov 4, 2026
Merged

sairon merged 1 commit into
masterfrom
split-whisper

Conversation

@sairon

@sairon sairon commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Keep only the app index metadata in whisper/.

Refs #4894

Summary by CodeRabbit

  • New Features
    • Added Whisper to the app catalog, pointing to its dedicated repository and image.
  • Changes
    • Removed the local Whisper build and service configuration, including its startup and discovery behavior.

Keep only the app index metadata in whisper/.

Refs #4894
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

The app catalog gains a Whisper entry that maps to a repository, target, and image. The local Whisper Dockerfile, build configuration, and s6 service and discovery files are removed. The yamllint ignore list gains the Whisper config path.

Changes: Whisper app definition

Layer / File(s) Summary
Catalog entry
.apps.yml, .yamllint
The app catalog adds the Whisper repository, target, and image mapping. The yamllint ignore list adds /whisper/config.yaml.
Local image build removal
whisper/Dockerfile, whisper/build.yaml
The local Dockerfile and build configuration are removed.
Service and discovery removal
whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/*, whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/*
The Whisper startup and exit-handling scripts, s6 service metadata, and discovery files are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: synesthesiam

Merge Risk: Minimal · up to 56d57

No concrete merge-blocking risk was established for the Whisper source move.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: moving the Whisper source to the home-assistant/app-whisper repository while retaining the app index metadata.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 42d31518-7902-47cf-9730-a6297a67579a
Commits

Reviewing files that changed from the base of the PR and between 20b8eea and 56d5749.

Files selected for processing: 15
  • .apps.yml
  • .yamllint
  • whisper/Dockerfile
  • whisper/build.yaml
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/dependencies.d/whisper
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/run
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/type
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/up
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/discovery
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/user/contents.d/whisper
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/dependencies.d/base
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/down-signal
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/finish
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/run
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/type
Files with no reviewable changes: 9
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/type
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/up
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/down-signal
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/type
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/discovery/run
  • whisper/build.yaml
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/run
  • whisper/Dockerfile
  • whisper/rootfs/etc/s6-overlay/s6-rc.d/whisper/finish

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@sairon
sairon merged commit ccb514d into master Nov 4, 2026
7 checks passed
@sairon
sairon deleted the split-whisper branch November 4, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants