fix(core): harden RedBox and autocompleter dialog DOM handling#167
Merged
TDannhauer merged 2 commits intoJun 18, 2026
Conversation
Replace destructive RB_window updates with non-destructive moves, and guard PrettyAutocompleter and KeyNavList teardown when nodes are detached. Fixes event dialog reopen failures in Kronolith.
ralflang
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Element#update()when moving dialog HTML intoRB_windowMotivation
Kronolith's event edit dialog uses RedBox with PrettyAutocompleter fields for attendees and tags. After closing the dialog once, reopening failed with
parentNode is nullerrors fromremoveChild, leaving overlays and autocompleter state inconsistent.Changes
RB_window.update(html)with a non-destructive move that parks previous children ondocument.bodyremoveItemNode(),updateInput(), andcurrentEntries(); remove orphaned box nodes before rebuilddestroy()when dropdown nodes are already detachedCompanion PR in
horde/kronolithwires these fixes into the event dialog lifecycle.Test plan