Implement attendee counter-proposal storage#168
Merged
Conversation
Add functionality to store attendee counter-proposals in the calendar.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds server-side persistence of EAS 16.1 attendee counter-proposals during MeetingResponse handling, by calling into Kronolith’s calendar API so proposed times can be re-synced to devices and later cleared when declined.
Changes:
- In
meetingResponse(), storeProposedStartTime/ProposedEndTimeon the calendar event viacalendar/storeAttendeeProposal. - On storage failure, log a warning and continue with the existing reply/COUNTER email flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if (!empty($proposedStart)) { | ||
| try { | ||
| $this->_registry->call('calendar/storeAttendeeProposal', [ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeetingResponsecommands onto the Kronolith calendar viacalendar/storeAttendeeProposal.Motivation
When an iOS client proposes a new meeting time, Horde already parses
ProposedStartTime/ProposedEndTime, validates disallow-counter flags, and sendsMETHOD=COUNTERmail to the organizer. Without storing the proposal on the server-side calendar event, Kronolith cannot:This change closes the inbound path: device → server storage → sync / clear on decline.
Changes
lib/Horde/Core/ActiveSync/Driver.phpIn
_meetingResponse(), after proposal validation and before sending COUNTER iTip mail:calendar/storeAttendeeProposalwith event UID, attendee email, and proposed start/end.test/Unit/ActiveSync/DriverMeetingResponseTest.phpAdd targeted unit coverage for attendee proposal persistence in
meetingResponse():ProposedStartTimeandProposedEndTimeare presentDependencies
Requires horde/kronolith (
storeAttendeeProposaland related counter-proposal APIs). Works together with horde/activesync (WBXML export/clear) and horde/imp (organizer accept/decline in webmail).Test plan
ProposedStartTime/ProposedEndTimefor attendeemeetingResponse()proposal storage and skip paths