feat(core): pass ActiveSync sync config to driver#170
Merged
Conversation
Wire $conf['activesync']['sync'] into Horde_Core_Factory_ActiveSyncBackend so horde/ActiveSync can read maxresponsetime for adaptive Sync response time budgeting (horde/ActiveSync#45).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$conf['activesync']['sync']from Horde config to the ActiveSync backend driver factory.Motivation
Companion to horde/ActiveSync adaptive Sync response time budgeting (horde/ActiveSync#45). The activesync package reads
maxresponsetimeviaHorde_ActiveSync_Driver_Base::getSyncConfig().Changes
Horde_Core_Factory_ActiveSyncBackend: add'sync' => $conf['activesync']['sync'] ?? []to driver params.Dependencies
activesync.sync.maxresponsetimeconfig key.Test plan
$conf['activesync']['sync']['maxresponsetime'] = 25and verify Sync truncates under load