feat: Adds Jwk::toPublicKey(array $jwk): PublicKey, the inverse of the existing Jwk::fromPublicKey().#2
Merged
Conversation
Member
|
Required for horde/base#109 |
ralflang
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Jwk::toPublicKey(array $jwk): PublicKey, the inverse of theexisting
Jwk::fromPublicKey().Supports RSA keys (kty=RSA, parameters n/e) and EC keys on curves P-256,
P-384 and P-521 (kty=EC, parameters crv/x/y). Unknown key types and
missing required parameters throw
InvalidArgumentException.Typical use case: verifying JWTs signed by an external OIDC provider.
The provider's JWKS endpoint returns an array of JWK objects; pass each
one to this method to obtain a PublicKey suitable for Rs256Verifier or
Es256Verifier.
Includes unit tests covering: RSA round-trip, EC P-256/P-384/P-521
round-trips, extra fields ignored, wrong key detection, and all error
cases (missing kty, unsupported kty, missing n/e, missing crv, unsupported
curve).
@ralflang My OIDC login implementation is ready. This is PR 2 of 3 required to
continue the implementation.