Repository navigation
Conversation
… in fragment strings Refactor string generation to improve readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Fragments.strings(summary_base=False)to slice source text at the match's source offset rather than its summary offset. For summarycat satand sourceThe Cat sat on the mat, the source fragment is nowCat sat, notThe Cat.Summary-based output, overlap matching, strict minimum-length filtering, and aggregate coverage/density/compression scores are unchanged. Adds regression coverage for differing offsets, original casing, multiple spans, thresholds, empty/no-overlap inputs, and unchanged metrics.
Validation
make quality: passed (repository-wide Ruff lint and formatting).pip checkandgit diff --check: passed.Broader metric suite: 291 passed, with two NLTK-data-dependent BLEU tests explicitly excluded. BLEU1/4 require
punkt_tab, whose download is blocked by this environment's proxy/SSRF safeguards; those safeguards were not disabled. Full GPU/provider CI was not run.