Repository navigation
fix(cache): stabilize solver task hashes - #1462
Open
jovial-liu wants to merge 1 commit into
Open
jovial-liu wants to merge 1 commit into
jovial-liu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task configs are hashed from
LightevalTaskConfig.__str__(lite=True). Inspect solver pipelines are stored as lists of functions, whose default repr includes a process-specific address. As a result, the same task gets a different sample-cache hash in each process and cannot reuse cached samples across runs.Represent solver callables using their module and qualified name, code, defaults, and captured values. Equivalent closures now produce the same hash, while different captured prompt text still produces a different hash.
Related to the cross-run cache observation in #1291.
Validation:
pytest tests/unit/tasks/test_registry.py -q— 9 passedruff checkandruff format --checkon the two changed files — passedgit diff --check— passed