Repository navigation
Add a Count column with the evaluated sample count to the markdown results summary - #1480
Open
amkkoussay wants to merge 1 commit into
Open
amkkoussay wants to merge 1 commit into
amkkoussay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #804
What this does
The markdown results summary (
make_results_table) now shows a Count column with the number of samples that were actually evaluated for each task, exported by the evaluation tracker asnum_samplesalongsideresults.Design choices
DetailsLogger.details) — i.e. the filtered/evaluated set behind the metrics, not the raw dataset size. This follows the concern raised on the issue thread about counts being misleading when filtering is applied.Changes
src/lighteval/logging/evaluation_tracker.py— exportnum_samplesin both results-dict builders (resultsproperty andgenerate_final_dict).src/lighteval/utils/utils.py— render theCountcolumn inmake_results_table.tests/unit/utils/test_utils.py— new unit tests for the column.Tests
tests/unit/utils/test_utils.py: 9/9 pass (6 existing + 3 new covering: count on the task's first metric row only, missing counts, partial counts).Happy to adjust the key name, column position, or the source of the count if you prefer a different design.