Repository navigation
refactor(gateway): use slices.SortFunc for peer ordering - #5551
Merged
Merged
Conversation
pfi79
reviewed
Aug 31, 2026
pfi79
reviewed
Aug 31, 2026
pfi79
requested changes
Aug 31, 2026
Signed-off-by: elonfliter <elonfliter@outlook.com>
elonfliter
force-pushed
the
feature_for_elon
branch
from
October 19, 2026 00:49
2e99622 to
9e5c617
Compare
Contributor
Author
|
@pfi79 Please review it again. |
pfi79
approved these changes
Oct 19, 2026
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
pfi79
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Improvement (improvement to code, performance, etc)
Description
Replace the gateway peer ordering comparator with
slices.SortFunc, preserving height ordering and local-peer preference.Additional details
The comparator now returns the
intresult required byslices.SortFunc; registry selection semantics are unchanged.Related issues
N/A (maintenance refactor).
Tested with
go test ./internal/pkg/gateway.