Repository navigation
hdr: reject modern RLE scanlines whose marker width does not match - #3121
Open
mamicicekel wants to merge 1 commit into
Open
mamicicekel wants to merge 1 commit into
mamicicekel wants to merge 1 commit into
Conversation
The Radiance per-component RLE marker encodes the scanline width in its last two bytes, but read_scanline only used those bytes to detect the new encoding. A crafted marker could therefore decode as long as the following runs still filled the buffer. Compare the encoded width before expanding the four components. Fixes image-rs#3119. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern Radiance RGBE scanlines start with
02 02plus a 16-bit width.read_scanlineused that prefix only to pick the new RLE path, so a marker whose width did not match the image still decoded when the following runs produced the right number of pixels.The encoded width is now compared with the scanline buffer before the four component runs are expanded. Unit tests cover a matching marker and both a shorter and a longer mismatch.
Fixes #3119.
This change was produced with LLM assistance.
Made with Cursor