Repository navigation
Conversation
ByGh00st
force-pushed
the
fix/bmp-subbyte-indexed-panic
branch
from
October 13, 2026 13:55
57d8ffd to
c9b2348
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
BmpDecoderagainst runtime panics by:width > 0andheight != 0).Details
set_indexed_color(true)was enabled on sub-byte palettized formats (1-bit, 2-bit, or 4-bit BMP),row.clone_from_slice(&indices[0..width])panicked with an out-of-bounds slice access. The decoder now returnsImageError::Unsupported.height == 0orwidth <= 0were previously accepted during header parsing. Downstream row arithmetic ((height - 1).try_into().unwrap()) resulted in aTryFromIntErrorunwrap panic. Headers with non-positive dimensions are now rejected cleanly during header validation.Testing
test_indexed_color_sub_byte_rejectedtest_bmp_zero_height_rejectedBackward Compatibility