Repository navigation
Add has_format method to ImageReaderOptions - #3136
Open
dylanheller wants to merge 1 commit into
Open
dylanheller wants to merge 1 commit into
dylanheller wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't check if
ImageReaderOptions::with_guessed_formatsuccessfully set a custom format that can't be represented asImageFormat.ImageReaderOptions::formatreturnsNonefor JXL or HEIC even though a format is set.We could use
ImageReaderOptions::into_decoderand check whether the result isErr(ImageError::Unsupported). But if the format is set, this method performs extra initialization work.Adding
has_formatwould help to quickly check whether a file is a supported image or not, until there is a unified image format type.