Port Stokes to new SystemKernels#327
Open
alexfikl wants to merge 3 commits into
Open
Conversation
alexfikl
commented
Jun 27, 2026
| } | ||
| } | ||
| ], | ||
| "./pytential/symbolic/stokes.py": [ |
There was a problem hiding this comment.
Pull request overview
This PR updates pytential’s symbolic Stokes machinery to use Sumpy’s newer SystemKernel APIs (e.g. StokesletSystemKernel, StressletSystemKernel) instead of the older per-component kernels, while also adding/cleaning up type annotations to reduce the pyright baseline footprint.
Changes:
- Port Stokeslet/Stresslet wrapper implementations from component kernels to system kernels and replace derivative handling with
AxisTargetDerivative. - Introduce/expand typing (including
ABCbase operator, annotated attributes, and@overridemarkers). - Remove now-obsolete pyright baseline suppressions for
pytential/symbolic/stokes.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pytential/symbolic/stokes.py |
Migrates symbolic Stokes wrappers/operators to SystemKernels and refactors derivative/stress expressions with added typing. |
.basedpyright/baseline.json |
Drops baseline entries corresponding to typing issues that are addressed by the refactor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably better viewed commit by commit, since the second commit adds type annotations and is a bit noisy.