Skip to content

feat: Add werkzeug instrumentation and unittests#871

Open
CagriYonca wants to merge 1 commit into
mainfrom
werkzeug
Open

feat: Add werkzeug instrumentation and unittests#871
CagriYonca wants to merge 1 commit into
mainfrom
werkzeug

Conversation

@CagriYonca
Copy link
Copy Markdown
Contributor

@CagriYonca CagriYonca commented May 8, 2026

Changed the middleware instrumentation to the monkey-patching approach as we use in other instrumentations.

$$ python-sensor % coverage report -m src/instana/instrumentation/werkzeug.py src/instana/instrumentation/wsgi.py src/instana/util/wsgi_utils.py 
Name                                      Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------
src/instana/instrumentation/werkzeug.py      31      0   100%
src/instana/instrumentation/wsgi.py          13      0   100%
src/instana/util/wsgi_utils.py               70      0   100%
-----------------------------------------------------------------------
TOTAL                                       114      0   100%

@CagriYonca CagriYonca self-assigned this May 8, 2026
@CagriYonca CagriYonca requested a review from a team as a code owner May 8, 2026 09:03
@CagriYonca CagriYonca force-pushed the werkzeug branch 2 times, most recently from c51cef4 to 2a8a1b1 Compare May 8, 2026 11:14
Comment thread src/instana/instrumentation/werkzeug.py Outdated
Comment thread tests/apps/werkzeug_app/__init__.py Outdated
@CagriYonca CagriYonca marked this pull request as draft May 11, 2026 07:29
@CagriYonca CagriYonca force-pushed the werkzeug branch 6 times, most recently from 5e1fc9f to edb4117 Compare May 11, 2026 13:44
@CagriYonca CagriYonca marked this pull request as ready for review May 11, 2026 13:49
@CagriYonca CagriYonca requested a review from pvital May 11, 2026 13:49
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little requests.

Comment thread tests/util/__init__.py
Comment thread tests/instrumentation/__init__.py
@CagriYonca CagriYonca requested a review from pvital May 12, 2026 08:28
@CagriYonca CagriYonca force-pushed the werkzeug branch 2 times, most recently from e48621a to d961757 Compare May 12, 2026 13:35
Signed-off-by: Cagri Yonca <cagri@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

@CagriYonca CagriYonca requested a review from GSVarsha May 13, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants