Skip to content

Prevent attempts to read dot-folders other than .vscode from reaching the server in server-side workspace folders #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-bsaviano merged 2 commits into from
Apr 14, 2026
Merged

Prevent attempts to read dot-folders other than .vscode from reaching the server in server-side workspace folders #1758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eeb5a8
Prevent attempts to read dot-folders other than `.vscode` from reachi…
isc-bsaviano Apr 14, 2026
fcff1b6
Update FileSystemProvider.ts
isc-bsaviano Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/providers/FileSystemProvider/FileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,19 @@ function validateUriIsCanonical(uri: vscode.Uri): void {
}
}

/**
* Throws `error` or a `vscode.FileSystemError.FileNotFound` error when `uri`
* is an invalid dot folder or is in an invalid dot folder. `.vscode`
* is allowed for any workspace folder, but other dot folders are only
* allowed in web app workspace folders. This filtering is done here to
* avoid spamming the server with requests that will never return meaningful data.
*/
function filterDotPaths(uri: vscode.Uri, error?: vscode.FileSystemError): void {
Comment thread
isc-bsaviano marked this conversation as resolved.
Outdated
if (!isfsConfig(uri).csp && uri.path.includes("/.") && !/\/\.vscode($|\/)/.test(uri.path)) {
throw error ?? vscode.FileSystemError.FileNotFound(uri);
}
}

export class FileSystemProvider implements vscode.FileSystemProvider {
private superRoot = new Directory("", "");

Expand Down Expand Up @@ -299,6 +312,7 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
public async stat(uri: vscode.Uri): Promise<vscode.FileStat> {
const api = new AtelierAPI(uri);
if (!api.active) throw vscode.FileSystemError.Unavailable("Server connection is inactive");
filterDotPaths(uri);
validateUriIsCanonical(uri);
let entryPromise: Promise<Entry>;
let result: Entry;
Expand Down Expand Up @@ -349,6 +363,7 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
}

public async readDirectory(uri: vscode.Uri): Promise<[string, vscode.FileType][]> {
filterDotPaths(uri);
if (uri.path.includes(".vscode/") || uri.path.endsWith(".vscode")) {
throw new vscode.FileSystemError("Cannot read the /.vscode directory");
}
Expand Down Expand Up @@ -465,6 +480,7 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
}

public createDirectory(uri: vscode.Uri): void | Thenable<void> {
filterDotPaths(uri, new vscode.FileSystemError("dot-folders are not supported by the server"));
uri = redirectDotvscodeRoot(uri, new vscode.FileSystemError("Server does not have a /_vscode web application"));
const basename = path.posix.basename(uri.path);
const dirname = uri.with({ path: path.posix.dirname(uri.path) });
Expand All @@ -481,6 +497,7 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
}

public async readFile(uri: vscode.Uri): Promise<Uint8Array> {
filterDotPaths(uri);
validateUriIsCanonical(uri);
// Use _lookup() instead of _lookupAsFile() so we send
// our cached mtime with the GET /doc request if we have it
Expand All @@ -495,13 +512,11 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
overwrite: boolean;
}
): void | Thenable<void> {
filterDotPaths(uri, new vscode.FileSystemError("dot-folders are not supported by the server"));
const originalUriString = uri.toString();
const originalUri = vscode.Uri.parse(originalUriString);
this._needsUpdate.delete(originalUriString);
uri = redirectDotvscodeRoot(uri, new vscode.FileSystemError("Server does not have a /_vscode web application"));
if (uri.path.startsWith("/.")) {
throw new vscode.FileSystemError("dot-folders are not supported by server");
}
validateUriIsCanonical(uri);
const csp = isCSP(uri);
const fileName = isfsDocumentName(uri, csp);
Expand Down Expand Up @@ -697,6 +712,7 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
}

public async delete(uri: vscode.Uri, options: { recursive: boolean }): Promise<void> {
filterDotPaths(uri);
uri = redirectDotvscodeRoot(uri, vscode.FileSystemError.FileNotFound(uri));
validateUriIsCanonical(uri);
const { project } = isfsConfig(uri);
Expand Down
Loading