[scd] Use database join to fetch uss availability in fetchOperationalIntents#1522
Open
the-glu wants to merge 3 commits into
Open
[scd] Use database join to fetch uss availability in fetchOperationalIntents#1522the-glu wants to merge 3 commits into
the-glu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow #1520
It switch the 'manual' join done to fetch uss availability to a direct join, avoiding an extra database round trip to fetch data.
Performance improvement with base lock is marginal: we get higher throughput at the start, but as test go performance is slighter lower (that may dues to test variations):
With the new lock introduced in previous PR, we also get higher throughput at the start and a slighter faster performance at the end (notice right and left are swapper):
In general thing seems better in term of latency and it avoid a database query, so I would say that better in general.