Repository navigation
Conversation
…!feat(backend)--disable-basic-authentication-by-default
matmair
added
api
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13169 +/- ##
==========================================
- Coverage 87.09% 87.09% -0.01%
==========================================
Files 1569 1569
Lines 111755 111789 +34
Branches 12150 12150
==========================================
+ Hits 97335 97361 +26
- Misses 14356 14364 +8
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
SchrodingersGat
pushed a commit
that referenced
this pull request
Nov 3, 2026
* fix basic auth without mfa * refactor order to use new basic auth class * remove session auth taht would bybpass mfa (mfa thing fixed in another session) * allign with other PRs prep for merge with #13169 * fix schema generation
…!feat(backend)--disable-basic-authentication-by-default
matmair
marked this pull request as ready for review
November 3, 2026 18:32
Member
|
@matmair I am happy with this, obviously we need to get all the tests fixed |
…!feat(backend)--disable-basic-authentication-by-default
Member
Author
|
@SchrodingersGat should we target this for 2.0 or 1.8? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables basic auth by default; re-enable via config; even with various fixes basic auth still has issues by design; prefer steering people to OAuth2 or Tokens