Skip to content

chore: app harness for testing RN/Expo apps with configured dependency versions#8994

Draft
russellwheatley wants to merge 15 commits intomainfrom
rn-and-expo-example
Draft

chore: app harness for testing RN/Expo apps with configured dependency versions#8994
russellwheatley wants to merge 15 commits intomainfrom
rn-and-expo-example

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-firebase Error Error Apr 24, 2026 3:24pm

Request Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new harness applications—one for bare React Native CLI and one for Expo development builds—to facilitate local validation of React Native Firebase packages. The changes include project scaffolding, configuration files, and utility scripts for syncing dependencies and building the apps. Feedback highlights critical issues with non-existent dependency versions and incorrect relative paths to node_modules that would fail in a hoisted workspace environment. Additionally, suggestions were made to improve script portability by replacing ripgrep with grep, to refine cleanup logic to prevent accidental data loss, and to ensure Metro resolves modules from the repository root.

Comment thread apps/build-harness-expo/package.json
Comment thread apps/build-harness/package.json
Comment thread apps/build-harness/android/build.gradle
Comment thread apps/build-harness/android/settings.gradle
Comment thread apps/build-harness/ios/Podfile
Comment thread apps/build-harness/metro.config.js
Comment thread scripts/build-harness-common.sh Outdated
Comment thread scripts/sync-build-harness.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant