chore: app harness for testing RN/Expo apps with configured dependency versions#8994
chore: app harness for testing RN/Expo apps with configured dependency versions#8994russellwheatley wants to merge 15 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces two new harness applications—one for bare React Native CLI and one for Expo development builds—to facilitate local validation of React Native Firebase packages. The changes include project scaffolding, configuration files, and utility scripts for syncing dependencies and building the apps. Feedback highlights critical issues with non-existent dependency versions and incorrect relative paths to node_modules that would fail in a hoisted workspace environment. Additionally, suggestions were made to improve script portability by replacing ripgrep with grep, to refine cleanup logic to prevent accidental data loss, and to ensure Metro resolves modules from the repository root.
…ADME in root of apps/
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter