Repository navigation
Docs updates - #357
Merged
Merged
Docs updates#357
Conversation
- Delete HCP Planner: remove stale proposalIds row left behind when
the query param was renamed to planIds
- Split proposal (cross-screen): response is now the full updated
proposal object, not {id, message}
- Create plan: note that creative/device combos are validated by an
external strategy-generation service with no fixed enumerable list,
and the generic rejection message when none is viable
- Generate custom strategies: note that the returned strategy id is
the external service's own id, not the real planner-api strategy id
needed by Activate proposal
- Update draft proposal: fix stale advertiserId -> politicalAdvertiserId
in the request schema and example (already correct in the sibling
create/update-ready endpoints and in this endpoint's own TS types)
- Proposal summary endpoints (device-type/channel-type/bid-landscape/
reach-impressions): fix stale 403/422 error text and drop a
"field" property that's not actually in the real response
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ProposalStatusEnum.java has id 7 = io_created / "IO Created", which HCPCampaignService sets as the terminal status on a successful HCP publish (parallel to how Political/generic proposals terminate at id 1 Converted instead). The shared proposalStatus EnumWidget only had ids 1-6, so hcp.mdx's statusId field never showed this as a possible value. Also documents the proposal-status-list endpoint's plannerTypeId query param and adds its HCP (plannerTypeId=2) example, which is the only place that returns this status list correctly but wasn't shown in our docs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planner API updates