Repository navigation
Fix/interpolation with compatible axis - #155
Merged
olivhoenen merged 2 commits intoOct 26, 2026
Merged
olivhoenen merged 2 commits into
olivhoenen merged 2 commits into
Conversation
A node was only interpolated over nodes of the same IDS and path, but only the coordinates of the target are used, and their number and names are already checked. Each IDS has its own time vector, even in one data entry: core_profiles/global_quantities/ip, summary/global_quantities/ip/ value and equilibrium/time_slice[:]/global_quantities/ip of ITER 130013/10 have 108 points each, 189 together. Any target node is now accepted, so they can be put on common coordinates. A node in an AoS of an IDS with heterogeneous time (time_slice[:]/time) could not be plotted at all: its per-slice times were not converted to numbers before taking their union. Assisted-by: Claude/opus-5
core_profiles, summary and equilibrium ip could each be plotted but not on the same plot. The grid took the IDSs of one entry to share their coordinates, yet each IDS has its own time vector: no common coordinates were asked for, and the x axis check refused the time path of another IDS (#summary/time against #core_profiles/time). A trace is now interpolated over a node drawn from each source of another IDS, and the x axis check compares the time path only when there is nothing to interpolate over. This needs the back-end to accept a target node of another IDS. Assisted-by: Claude/opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #134 and this comment
Use-case: now allow plotting
core_profiles/global_quantities/ip,equilibrium/time_slice/global_quantities/ipandsummary/global_quantities/ipon the same plot