Repository navigation
fix(ci): repair template tooling and bound headless credential smoke - #1
Merged
Merged
Conversation
itsjeremyjohnson
marked this pull request as ready for review
October 6, 2026 04:02
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 1ba87472-8a74-4d7a-872f-1d8d4c73f57c) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template filtered CI to
maineven though its default branch isfeat/initial-template, and installed a v1 linter against a v2 configuration. This fixes the triggers and tool pins, updates the jose2go seed to 1.7.0, and separates the macOS native empty-keyring probe from a bounded encrypted-file credential roundtrip for headless runners.Linux maintainer gates use Go 1.25 because golangci-lint 2.9 requires it. The module and macOS/Windows build lanes keep Go 1.22. The restored gates exposed existing formatting and lint defects; the follow-up fixes preserve command precedence and credential settings, propagate JSON output errors, preserve wrapped keyring errors, and add focused keyring regression cases. A JSON output failure can occur after credential storage succeeds.
Validation at
6fcc8e78828c04702977c59b13a73100dc69a978: all three CI jobs passed, including Linux formatting/lint/tests, Go 1.22 macOS/Windows builds, the native empty-store probe, and asserted encrypted-file write/read/remove behavior.internal/secretshas tests; six other packages report no test files. Go 1.22 is verified as a build contract; its test suite was not run. Native macOS stored-secret reads remain unexercised.The complete remote tree matches the reviewed changes. Placeholder names, production keychain trust settings, and the tag-triggered release workflow are preserved.
Note
Low Risk
Mostly CI, dev tooling, and error-handling polish; credential behavior is tightened for CI assertions without changing production keychain trust settings.
Overview
Repairs template CI so it runs on the default branch (
feat/initial-template) and aligns maintainer tooling with golangci-lint v2 (Linux uses Go 1.25 for fmt/lint/test; macOS/Windows stay on Go 1.22 for build smoke). Dev tool pins in the Makefile are bumped (gofumpt, goimports, golangci-lint v2.9.0), and jose2go is updated to 1.7.0.macOS credential checks are split: a 1-minute native keychain probe for an empty store, then a bounded encrypted file backend roundtrip (
set-key→ JSONauth status→remove) with explicitPLACEHOLDER_CLI_KEYRING_*env and Python assertions onhas_key/env_overrideso CI cannot pass without real storage behavior.Follow-up code fixes from restored gates: auth commands propagate JSON write errors, keyring
HasKeywraps non–not-found failures, blank generic secret keys use a shared sentinel, plus new secrets regression tests. README documents the split Go versions and template adaptation expectations.Reviewed by Cursor Bugbot for commit 6fcc8e7. Bugbot is set up for automated code reviews on this repo. Configure here.