Fix assert cmd deprecation and bump several other dependencies#146
Merged
Fix assert cmd deprecation and bump several other dependencies#146
Conversation
This commit tries to resolve the issue #145 by using the macro for obtaining the cargo command. This is required in order to not have a breaking change in future Rust versions. Unfortunately, the currently used version of [`assert_cmd`] does not provide the suggested fix, so a newer version (at least `2.1`) is re- quired. Unfortunately this in turn requires a Rust version of at least 1.74, so this commit also includes a bump of the MSRV. Only the minimal change in dependencies is done, so that the diff is smaller. With the higher MSRV, a bump of several dependencies can be done in a future commit. Fixes of #145. [`assert_cmd`]: https://docs.rs/assert_cmd/2.0.5/assert_cmd/cargo/fn.cargo_bin.html
Thanks to the newer MSRV, several packages can be upgraded now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve the issue #145 by using the macro for
obtaining the cargo command. This is required in order to not have a
breaking change in future Rust versions.
Unfortunately, the currently used version of
assert_cmddoes notprovide the suggested fix, so a newer version (at least
2.1) is re-quired.
Unfortunately this in turn requires a Rust version of at least 1.74, so
this commit also includes a bump of the MSRV. Only the minimal change in
dependencies is done, so that the diff is smaller. With the higher MSRV,
a bump of several dependencies is done as well, so that this repository
is more up-to-date.
Fixes #145.