Repository navigation
ci: Ask setup-ruby for the Ruby 3.4 series, not .ruby-version's exact patch - #181
Merged
Merged
Conversation
Ubuntu 26.04 runners only carry each series' newest patch, so 3.4.8 is a 404 there and the canary's Linux legs failed in setup-ruby. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six release jobs read .ruby-version. On Ubuntu 26.04 only each series' newest patch exists, and setup-ruby's Windows builds trail it: they stop at 3.4.11, so an exact 3.4.12 cannot install in build-windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bundler adds the host platform on macOS 27. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last night's canary failed on both Ubuntu legs before any test ran, in
ruby/setup-ruby:ubuntu-lateststarted moving to Ubuntu 26.04 on October 19 (actions/runner-images#14748). setup-ruby only builds the newest patch of each series there. Every setup-ruby step that gave noruby-versionread.ruby-version, which pinned 3.4.8.ruby/setup-rubystep incanary.yml,main.ymlandrelease.ymlnow asks forruby-version: '3.4'. Inmain.yml's package-manager matrix, thedefaultlegs now map to'3.4'; the'4.0'legs are unchanged, and theif: matrix.ruby == 'default'conditions still match.release.yml's verify jobs already asked for'3.4', but six jobs (platforms, build-darwin, build-linux, build-windows, build-plain, publish) did not.release.ymlmatters on Windows too. setup-ruby's Windows builds stop at 3.4.11, so an exact 3.4.12 cannot install there. With only the.ruby-versionbump,build-windowswould have failed on the next release..ruby-versionis 3.4.12, and AGENTS.md says so too.Gemfile.lockgains thearm64-darwin-27platform, which Bundler added on a macOS 27 host.Test Coverage
Application code paths: 0. The changes are CI workflow config,
.ruby-version, one lockfile platform and one doc line. No test reads any of them, so the CI runs are their test.Coverage gate: could not determine percentage (no application code paths), so it was skipped.
Tests ran: test-all count unavailable (runner summary not recognised; the suites printed 812 Ruby runs, Go ok, 9 Bun tests)
Pre-Landing Review
One finding, fixed with approval:
release.yml's six setup-ruby steps read.ruby-version(build-windowscannot install 3.4.12 from setup-ruby's Windows table). A second pass found nothing.Gate edits: none detected (12 listed, 1 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Adversarial review: the Claude pass completed and found no defect in the diff. It noted the bundled-with gap below for the PR run to settle.
Outside review (Codex): missing coverage. Its verdict was unverified: it reported no findings but without severity tags.
Exploratory QA
Functional surface: CI jobs, smoke budget, 4 probes. Every probe was a read of GitHub state.
'3.4'to 3.4.12.'3.4'to 3.4.12.'3.4'to 3.4.11.release.yml'sbuild-windowswould have asked for. Therelease.ymlcommit fixes it.main.yml(this PR runs it) andrelease.yml, which adry_rundispatch would check.Design Review
No frontend files changed, so design review was skipped.
Eval Results
No prompt-related files changed, so evals were skipped.
Scope Drift
Scope Check: CLEAN. The one incidental change is the
Gemfile.lockplatform line, committed on its own.Plan Completion
Plan completion audit: not run (no plan is bound to this branch and no docs/designs/ file matches). Fix: add "Plan: " to the PR body, or run /autoplan.
Verification Results
No plan-specific verification items.
Watch in this PR's run:
ruby-test: the appraisal gemfiles sayBUNDLED WITH 2.6.8, and they now run on a new image and patch.package-manager'4.0'legs: they now resolve to 4.0.9, published today.first-run,bun-testandrubocop: the canary covers none of these.TODOS
No TODO items completed in this PR.
Documentation
Status: current. No documentation edits were needed.
Scope: the branch diff against base 1001765 (three workflow files pinning
ruby/setup-rubyto the '3.4' series) plus the unstaged.ruby-version(3.4.8 to 3.4.12), AGENTS.md (the matching Ruby version line) and Gemfile.lock (an addedarm64-darwin-27platform). I inventoried every authored doc and read AGENTS.md, README.md and the consumer guide's CI snippet against these changes.Documentation health:
.ruby-version.setup-rubysnippet is for consumer apps.Coverage debt: AGENTS.md's CI section does not note that every
setup-rubystep pins '3.4' (optional, not added). Diagram drift: none.Test plan
bin/test-allunder Ruby 3.4.12 (compile, Go, Ruby withSTAGE_A=1, Bun): all ok; 812 runs, 0 failures, 0 errors, 7 skipsgh workflow run canary.yml --ref ci/ruby-3.4-series: 6/6 jobs green, with Ubuntu on 26.04 / Ruby 3.4.12jactionlinton the three workflows: no new findings (release.yml's 7cache-poisoningerrors are on master too)main.ymlon this PRgh workflow run release.yml --ref ci/ruby-3.4-series -f dry_run=true🤖 Generated with Claude Code