Fix misori_tetragonal identity bug and add c2ImageD11 cross-test CI#10
Merged
Conversation
misori_tetragonal: the trace comparison was checking m2 > m3 (off-diagonal vs c-axis) instead of m1 > m2 (diagonal vs off-diagonal), causing the identity case to return 1 instead of 3. This matches the fix already applied in c2ImageD11 0.3.0. Also noted: refine_assigned infinite-loop bug (i++ instead of j++) was already fixed in commit acb51d5. CI: add a workflow that builds c2ImageD11 from git head (using their checked-in pre-generated wrappers, no c2py23 dependency) and runs the full ImageD11 test suite with IMAGED11_USE_C2=1, so we break when upstream changes break our compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
misori_tetragonal: the trace comparison was checking m2 > m3 (off-diagonal vs c-axis) instead of m1 > m2 (diagonal vs off-diagonal), causing the identity case to return 1 instead of 3.
This matches the fix already applied in c2ImageD11 0.3.0.
Also noted: refine_assigned infinite-loop bug (i++ instead of j++) was already fixed in commit acb51d5.
CI: add a workflow that builds c2ImageD11 from git head (using their checked-in pre-generated wrappers, no c2py23 dependency) and runs the full ImageD11 test suite with IMAGED11_USE_C2=1, so we break when upstream changes break our compatibility.