feat: optimize enum schema generation by grouping unit variants#1364
Closed
domenkozar wants to merge 2 commits intojuhaku:masterfrom
Closed
feat: optimize enum schema generation by grouping unit variants#1364domenkozar wants to merge 2 commits intojuhaku:masterfrom
domenkozar wants to merge 2 commits intojuhaku:masterfrom
Conversation
Group simple unit enum variants into a single schema to reduce schema size and improve OpenAPI document readability. Complex unit variants with titles or descriptions remain individual schemas.
Author
|
I think it's better to solve this using simplifier pass: OpenAPITools/openapi-generator#21041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a prototype I've put together to see if I can unblock myself.
The general idea is that even if one of the enums is special, we generate the rest of enums as one.