chore: update version numbers and dependencies for flutter_secure_sto…#1096
chore: update version numbers and dependencies for flutter_secure_sto…#1096SunnatilloShavkatov wants to merge 6 commits intojuliansteenbakker:developfrom
Conversation
juliansteenbakker
left a comment
There was a problem hiding this comment.
Thank you for the changes!
| description: Windows implementation of flutter_secure_storage. Please use flutter_secure_storage instead of this package. | ||
| repository: https://github.com/mogol/flutter_secure_storage | ||
| version: 4.1.0 | ||
| version: 4.1.1 |
There was a problem hiding this comment.
We should change this to 4.2.0 since the win32 upgrade is a breaking change update.
There was a problem hiding this comment.
Good catch — updated to 4.2.0 since the win32 upgrade is a breaking change.
… streamline dependency installation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1096 +/- ##
==========================================
Coverage 96.99% 96.99%
Complexity 146 146
==========================================
Files 17 17
Lines 533 533
Branches 48 48
==========================================
Hits 517 517
Misses 9 9
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: TitouanBourveauEXFO <135720545+TitouanBourveauEXFO@users.noreply.github.com>
|
@juliansteenbakker can you approve this PR? This package blocks our project from upgrading to new version of other packages |
|
JFYI I added this branch as dependency for testing and get this exception now: Did you test your changes on Windows? I tested your changes by changing the dependencies like this: dependencies:
# ...
flutter_secure_storage:
git:
url: https://github.com/juliansteenbakker/flutter_secure_storage.git
ref: 46496f13a08893ee78530dabdcb5476a6167e5b3 # the latest commit from you
path: flutter_secure_storage
flutter_secure_storage_windows:
git:
url: https://github.com/juliansteenbakker/flutter_secure_storage.git
ref: 46496f13a08893ee78530dabdcb5476a6167e5b3
path: flutter_secure_storage_windowsOr is there anything else I need to replace in order to test your changes? |
I haven't yet, i'm keen on getting #1093 merged first before this, in order to automatically pick up issues like this. Thanks for testing! |
This pull request updates dependencies across multiple packages in the
flutter_secure_storageecosystem, introduces compatibility fixes for Windows, and includes minor code and documentation improvements. The main focus is on ensuring compatibility with newer versions of dependencies and addressing platform-specific issues.Dependency Updates and Compatibility:
Updated
plugin_platform_interface,flutter_secure_storage_platform_interface, and other dependencies inpubspec.yamlfiles across all packages to ensure compatibility with newer versions and improve stability. This includes bumping versions forffi,win32,meta,mocktail,mockito,very_good_analysis,path, andpath_provider. [1] [2] [3] [4] [5] [6] [7] [8]Updated the
flutter_secure_storage_webandflutter_secure_storage_windowspackage versions to reflect the changes and fixes. [1] [2]Windows Platform Fixes:
flutter_secure_storage_windowsfor compatibility withwin326.0.0, including changes to error handling and memory management influtter_secure_storage_windows_ffi.dart. [1] [2] [3] [4] [5]Web Platform Improvements:
deleteAllmethod influtter_secure_storage_web.dartby using a more concise functional style for removing items.readAllwhen storage is modified concurrently.Build System and Plugin Registration:
jnito the FFI plugin lists for Linux and Windows example builds to support FFI plugins. [1] [2]These changes collectively improve package stability, maintain compatibility with the latest dependencies, and address platform-specific issues, especially for Windows users.