Repository navigation
Stack the cursor's plane at the top of what the CRTC blends (P-106) - #127
Merged
Merged
Conversation
Neither side wrote the cursor plane's zpos, so an overlay taken for the
cursor kept whatever it had. Left at the 0 every overlay starts at, it
shared the primary's blend stage, and the SA8155P refuses two
overlapping planes on one stage ("invalid coordinates, stage:0"), so
the cursor never committed there at any position.
The plane is now written with the top of its zpos range, capped below
the CRTC's blend-stage limit, as drm-cxx's in-progress cursor fix for
one. The size probe's test commits carry it too, and it survives a
pause and resume.
The cursor device tests now probe their plane registry rather than
build one without zpos ranges or a blend limit, which the renderer
could not have stacked from. The rotation test follows: it expects the
hardware to be asked for the turn when the probed plane can do it.
The P-101 row records the agreed divergence from drm-cxx's cursor fix,
which clips an overlay-backed cursor's geometry where drmkit shifts the
sprite.
Signed-off-by: Joel Winarske <joel.winarske@linux.com>
jwinarske
force-pushed
the
fix/cursor-zpos
branch
from
October 20, 2026 19:25
f513a90 to
7acbf18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #121 on drm-cxx#384, from the SA8155P re-test.
The problem: neither drmkit nor drm-cxx wrote the cursor plane's
zpos. An overlay taken for the cursor kept whatever value it had. Left at the 0 every overlay starts at, it shared the primary's blend stage. The SA8155P refuses two overlapping planes on one stage (_sde_crtc_validate_src_split_order"invalid coordinates, stage:0"), so the cursor never committed there at any position.The fix: the cursor's plane is now written with the top of its
zposrange, capped below the CRTC's blend-stage limit. That's the rule drm-cxx's in-progress cursor fix for #384 uses.zposor a fixed one, so i915, amdgpu and vkms are unchanged.The tests:
the_cursor_stacks_at_the_top_of_what_the_crtc_can_blend.PlaneRegistry::probe). The hand-built one had nozposranges or blend limit for the renderer to stack from.SA8155P, DP-4 (stale SDE plane state cleared first, every plane's
zposreset to 0):a_cursor_off_the_top_left_corner_commits_vkmsWithout the
zposreset, main passed too on this boot. Whether main fails depends on thezposvalues weston leaves behind, which vary by boot.One test still fails on the board on both builds:
the_cursor_leaves_an_overlay_this_crtc_shows_vkms. It lights a 4K mode, which the board's shared-display layer refuses ("roi 4096x2160 exceeds base mode 1280x720"). That's a rig limitation, not this change.Docs:
Checks: clippy over the workspace with all features, workspace tests, the cursor tests on vkms and rustdoc all pass. semver-checks reports no update needed.