Skip to content

fix: render ModelConfig TLS in Helm chart#1999

Open
andreivince wants to merge 1 commit into
kagent-dev:mainfrom
andreivince:fix/modelconfig-chart-tls
Open

fix: render ModelConfig TLS in Helm chart#1999
andreivince wants to merge 1 commit into
kagent-dev:mainfrom
andreivince:fix/modelconfig-chart-tls

Conversation

@andreivince

Copy link
Copy Markdown
Contributor

Closes #1991.

The chart-generated default ModelConfig already rendered provider, model, API key secret, defaultHeaders, and provider-specific config, but it dropped providers.<name>.tls. That meant the CRD supported ModelConfig TLS settings, while users installing through the chart could not pass them into the default ModelConfig.

This adds the missing TLS passthrough in templates/modelconfig.yaml and covers it with a Helm unit test. I also added a small commented example in values.yaml so the supported shape is easier to find.

I verified this with:

  • Added the Helm regression test first and confirmed it failed on missing spec.tls.*
  • helm unittest -f 'tests/modelconfig_test.yaml' helm/kagent
  • make helm-test
  • helm lint helm/kagent
  • helm lint helm/kagent-crds
  • Exact CI Helm v3.18.0 against the kagent, querydoc, and grafana-mcp chart unit tests
  • Render checks for all built-in provider defaults with TLS set
  • kubeconform against the rendered chart and CRDs
  • Temporary kind cluster with CRDs installed and a server-side Helm dry run using TLS values

Signed-off-by: andreivince <andreivince21@gmail.com>
Copilot AI review requested due to automatic review settings June 11, 2026 17:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the bug Something isn't working label Jun 11, 2026
@andreivince

Copy link
Copy Markdown
Contributor Author

:)

@andreivince

Copy link
Copy Markdown
Contributor Author

Pretty sure gotta re run the build, had the same issue my last PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Helm chart providers.<name> values do not expose ModelConfig spec.tls — TLS config unreachable for chart-generated default ModelConfig

2 participants