fix(ui): show agent edit control and prevent chat horizontal overflow#2002
Open
amit-chaubey wants to merge 1 commit into
Open
fix(ui): show agent edit control and prevent chat horizontal overflow#2002amit-chaubey wants to merge 1 commit into
amit-chaubey wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves the Agent Details sidebar header/layout to better handle long agent refs and model strings, while also adjusting chat layout containers to prevent horizontal overflow issues. It also adds a dedicated unit test and updates the Jest environment to support responsive hooks in jsdom.
Changes:
- Refactored
AgentDetailsSidebarheader to include an always-visible edit control and split agent ref/model into separate truncated lines. - Updated chat layout container classes to use
min-w-0/flex wrappers for better overflow behavior. - Added jsdom
matchMediamock and a new sidebar test validating edit link + long-text rendering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/components/sidebars/tests/AgentDetailsSidebar.test.tsx | Adds coverage for edit link accessibility/name and long agent ref/model rendering behavior. |
| ui/src/components/sidebars/AgentDetailsSidebar.tsx | Refactors sidebar header + truncation behavior; moves edit control to header and separates agent ref/model lines. |
| ui/src/components/chat/ChatLayoutUI.tsx | Adjusts main layout wrapper to flex/min-width constraints to reduce horizontal overflow. |
| ui/src/components/chat/ChatInterface.tsx | Replaces min-w-full with min-w-0 on root container to prevent unwanted horizontal scrolling. |
| ui/jest.setup.ts | Adds window.matchMedia mock required by sidebar responsive behavior under jsdom. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+236
to
+237
| const agentRef = `${selectedTeam?.agent.metadata.namespace}/${selectedTeam?.agent.metadata.name}`; | ||
| const editHref = `/agents/new?edit=true&name=${selectedAgentName}&namespace=${currentAgent.agent.metadata.namespace}`; |
Comment on lines
+35
to
+47
| Object.defineProperty(window, "matchMedia", { | ||
| writable: true, | ||
| value: jest.fn().mockImplementation((query: string) => ({ | ||
| matches: false, | ||
| media: query, | ||
| onchange: null, | ||
| addListener: jest.fn(), | ||
| removeListener: jest.fn(), | ||
| addEventListener: jest.fn(), | ||
| removeEventListener: jest.fn(), | ||
| dispatchEvent: jest.fn(), | ||
| })), | ||
| }); |
Collaborator
|
thanks for your PR -- can you sign the DCO? |
Move the edit action to the Agent Details header so long agent names and model strings no longer clip it, and constrain the chat column with min-w-0. Signed-off-by: AmitChaubey <amit.katyayana@gmail.com>
amit-chaubey
force-pushed
the
fix/ui-agent-details-edit-button-clipping
branch
from
4595531 to
6f6c46f
Compare
Author
Done — signed off and force-pushed. Also addressed the two Copilot review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the agent edit button being clipped in the Agent Details sidebar when agent names or model strings are long. Moves the edit action into the sidebar header and adds
min-w-0on the chat column to prevent horizontal overflow.Test plan
cd ui && npm test -- AgentDetailsSidebar