Repository navigation
Conversation
kean
force-pushed
the
fix/data-loading-range-progress-empty
branch
from
September 26, 2026 20:40
782759b to
bed3081
Compare
kean
force-pushed
the
fix/data-loading-range-progress-empty
branch
2 times, most recently
from
November 1, 2026 15:50
6dcb09f to
b274a62
Compare
The local-resource fast path sent whatever `Data(contentsOf:)` returned, so a zero-length file or an empty `data:` URL succeeded with no data, and the image request failed in the decoder instead.
…nown The progress total added the resumed bytes to `-1`, which put it below the bytes already received, so the task read as complete from its first chunk.
`DataLoader` rejects a "416 Range Not Satisfiable" before the pipeline sees the response, which looked like a request that ended before the server responded, so the rejected range was put back and sent again on every attempt.
kean
force-pushed
the
fix/data-loading-range-progress-empty
branch
from
November 3, 2026 00:51
b274a62 to
29071c1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rangeagain on every later attempt, so the image couldn't load until the entry left the resumable data storage.DataLoaderrejects the response before the pipeline sees it, sourlResponsewasnil, which looked like a request that ended before the server responded, and the rejected range was put back. The data is now dropped when the range was rejected.Content-Lengthreported a total below the bytes already received (fraction == 1from the first chunk). The total added the resumed bytes to-1; an unknown length is now reported as unknown, the way it is for a download that was never resumed.data:URL succeeded with zero bytes fromdata(for:), andimage(for:)failed in the decoder. The local-resource fast path skipped the empty-data check the loader anddataclosure paths have; it now fails with.dataIsEmptylike them.