Repository navigation
Conversation
Opt-in with ImagePipeline.Configuration.failureCooldown. After a 404 or a 410, the loads of that URL fail with ImagePipeline.Error.urlInCooldown, after the caches and before the data loading queue, until the window ends. ImageLoader.reload() and .skipFailureCooldown reach the server anyway.
kean
force-pushed
the
feat/failed-url-cooldown
branch
from
November 3, 2026 00:51
c5a6d70 to
aa4fe52
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in
failureCooldown: after a404or410, the pipeline stops requesting that URL for a while, so a dead image in a feed doesn't cost a request per cell. The plan had cut this, and it's back by request. Loads fail with the new.urlInCooldown(error:), after the caches and before the queue;ImageLoader.reload()and.skipFailureCooldownstill reach the server.Proof
loadWithinTheWindowMakesNoRequestand others) andaURLInCooldownDoesNotWaitForTheQueuehangs. 8 other mutations (no expiry, any status code, no bypass, unbounded, ...) are each caught.ImagePipelinePreviewPolicyTests, which fails the same way on base in a full local run, and passes 14/14 alone on both..reload(id:)in Add reload, keepsPreviousImage, failureView, and imageTransition to LazyImage #1100 callsload, so it needs the same bypass asreload(), and Add retries to the pipeline #1072 must record the failure after its last retry. Xcode 26.0 is CI only.