Repository navigation
feat(consolewindow): stop background spawns from flashing console windows on Windows - #308
Merged
Merged
Conversation
…dows on Windows On Windows, kenn-io daemons run without a console. Each console program a daemon starts, such as git or gh, then opens its own visible window for a moment unless the spawn sets CREATE_NO_WINDOW. Repos that forget consolewindow.Hide at one call site flash a window every time that code runs. consolewindow.CommandContext returns a command that is already hidden, and the shared lint config now bans exec.CommandContext in favor of it, so a new spawn is hidden unless its author opts out with a nolint reason. A per-function analyzer that checked for a Hide call would miss commands built in one function and started in another, and forge already uses this wrapper-plus-ban approach with its own procutil package. The main-package exclusion now matches only the exec.Command cancellation rule. Daemons live in main packages, so the old pattern would have exempted the code this rule is for. Interactive spawns, such as git credential prompts and ssh with BatchMode=no, keep exec.CommandContext because they need the caller's console. Every repo picks up the ban on its next kit bump and `kennlint config` run.
roborev: Combined Review (
|
This was referenced Nov 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kenn daemons on Windows stop flashing console windows, because shared lint now bans
exec.CommandContextforconsolewindow.CommandContext, which hides the window.kenn-io/roborev#1665, kenn-io/kata#922, kenn-io/msgvault#1845, and kenn-io/docbank#1313 clear those repos ahead of the ban. All have merged so this is good to go.