Repository navigation
fix(gitcmd): stop windows git helpers without taskkill - #313
Conversation
Git cancellation must stop HTTP helpers as well as their parent. The one-second taskkill budget could expire before tree termination, after which the fallback killed only Git and left helpers connected.
roborev: Combined Review (
|
A process snapshot must still identify a helper after it exits. Otherwise a vanished intermediate can hide live descendants, and a reused PID can select an unrelated process during cancellation.
roborev: Combined Review (
|
The Windows cancellation test failed on every run because it expected the shell to be Git's only child. Git starts without a console window, so Windows gives it a new hidden console. The host process for that console is also a child of Git. The test now skips the console host and still requires exactly one other child. A failure lists the image names of Git's children, so an unexpected process tree is easy to diagnose. Generated with Claude Code (claude-opus-5-5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
roborev: Combined Review (
|
Windows callers can cancel Git network operations without leaving HTTP helpers connected, fixing the cancellation failure in run 101.
Terminate descendants through Windows process APIs so taskkill's one-second timeout cannot fall back to killing only Git. Keep the existing cancellation and pipe-drain deadlines.