Skip to content

fix: anchor geocoder pin icon at bottom tip (#2401) #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierreeurope wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: anchor geocoder pin icon at bottom tip (#2401) #3320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/layers/src/icon-layer/icon-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,33 @@ export const pointVisConfigs: {
billboard: 'billboard'
};

// Icons whose bottom tip should be anchored at the geographic position
const BOTTOM_ANCHOR_ICONS = ['place', 'pin'];

function flatterIconPositions(icon) {
// had to flip y, since @luma modal has changed
return icon.mesh.cells.reduce((prev, cell) => {
const positions = icon.mesh.cells.reduce((prev, cell) => {
cell.forEach(p => {
prev.push(
...[icon.mesh.positions[p][0], -icon.mesh.positions[p][1], icon.mesh.positions[p][2]]
);
});
return prev;
}, []);

// For pin-like icons, shift geometry so the bottom tip is at origin (y=0)
// This ensures the pin tip points at the actual geographic location
if (BOTTOM_ANCHOR_ICONS.includes(icon.id)) {
let minY = Infinity;
for (let i = 1; i < positions.length; i += 3) {
if (positions[i] < minY) minY = positions[i];
}
for (let i = 1; i < positions.length; i += 3) {
positions[i] -= minY;
}
}

return positions;
}

export default class IconLayer extends Layer {
Expand Down