Skip to content

Document the Kernel card provider and simplify wallet selection - #718

Open
ehfeng wants to merge 4 commits into
mainfrom
hypeship/kernel-card-guide
Open

ehfeng wants to merge 4 commits into
mainfrom
hypeship/kernel-card-guide

Conversation

@ehfeng

@ehfeng ehfeng commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

The wallet chooser omits the Kernel card provider, leaving developers to piece together enrollment, card custody, and purchase approvals from the API reference and embedded capture guide.

Add a short provider guide, a three-row provider chooser, and links from payment setup and embedded capture. The guide uses numbered steps and an approval table, with fallback behavior behind an expandable section. Detailed limits and expiry values stay in the API reference. Note that Visa purchases require merchant_country, and show each provider's environment in the chooser. Also clarify cross-origin payment-field support and link the existing pricing answer. Lay out the payments diagram vertically with shared setup and both checkout branches visible together.

Testing

  • bunx mint@4.2.930 broken-links — no broken links.
  • bunx mint@4.2.930 dev --port 3000 — all five affected pages return HTTP 200 without MDX compilation errors.
  • Visually reviewed the new guide in Chromium, including its approval table and collapsed fallback section.
  • Visually checked the unified payment diagram in Chromium at 1440px desktop and 390px mobile widths.
  • Editorial and full-diff self-review; git diff --check passes.

Documentation only; no application behavior changed. The KERNEL card guide adds TypeScript, Python, and CLI examples, checked against the API and CLI.


Note

Low Risk
Documentation-only updates to MDX and site navigation; no product code or API behavior changes.

Overview
Adds a dedicated KERNEL card provider guide covering provider: "kernel" enrollment (hosted or embedded), purchase authorization, network-token vs fallback behavior, and TypeScript/Python/CLI examples. The new page is wired into the Payments nav and linked from payments setup, vault overview, embedded card capture, and the wallets overview.

The wallets overview drops the two-card chooser and long Link vs Agentcard comparison in favor of a compact three-integration table (KERNEL card, Link, Agentcard) and points readers at each provider guide.

Payments on KERNEL retools the lifecycle Mermaid diagram to a top-down layout that shows shared wallet setup plus separate fill and Agentcard checkout branches, and adds Get started links for KERNEL card and pricing. vaults/fill now states that selectors can target inputs in cross-origin payment iframes, without implying processor acceptance.

Reviewed by Cursor Bugbot for commit ff853b7. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify

mintlify Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Kernel 🟢 Ready View Preview Oct 21, 2026, 7:06 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@ehfeng
ehfeng marked this pull request as ready for review October 21, 2026 18:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T18:21:36.619189Z 0a83a6c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@courtney918 courtney918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Visa needs merchant_country: step 2 in kernel.mdx lists merchant, amount, and currency, but Visa card requests are rejected without spec.merchant_country. Worth calling out in step 2 or the Visa table row.
  2. No code examples in kernel.mdx: AGENTS.md asks for TS + Python, and the link/agentcard guides have CLI commands. A minimal create-wallet / create-card snippet would help.
  3. Diagram arrow: C -->|fill| T points from the card to the trusted controller, which implies card data reaches the controller. Pointing both C and T into F (as before) is more accurate.

@courtney918 courtney918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional / non-blocking:

  1. Overview comparison: the new table drops test vs live mode (link is live-only, agentcard has test_mode), which affects how people build. Might be worth keeping that one detail.
  2. vaults/overview.mdx: the "Payment items" section still only links the link/agentcard item references; could add KERNEL card.
  3. PR body: the Pylon customer issue link probably shouldn't be in a public repo's PR description.

Visa card requests are rejected without spec.merchant_country, so the guide
now says so in the purchase steps and approval table. Add TypeScript, Python,
and CLI examples for creating the wallet and authorizing a card. The wallet
chooser notes each provider's environment, and the vaults overview links the
KERNEL card guide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ehfeng

ehfeng commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

On the diagram arrow: the |fill| label names which branch a prepared card takes, and the Agentcard branch is labeled the same way. It doesn't mean card values pass through the controller. The controller box itself says it supplies "references and selectors", and the fill box says KERNEL fills the fields and returns outcomes with no card values. Drawing both into F again would lose the side-by-side fill vs agentcard split, which is the main point of the new layout. If the label still reads as data flow, I'm happy to rename it to something like fill path.

1, 2, 4, 5 and the PR body are addressed in ff853b7. Thanks for catching the Visa country requirement.

@ehfeng
ehfeng requested a review from courtney918 October 21, 2026 20:22

This branch was successfully deployed

1 active deployment
staging — ff853b75 Deployed Oct 21, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants