Skip to content

Escape image names in path parameters - #51

Merged
chruffins merged 1 commit into
mainfrom
hypeship/escape-image-path-params
Aug 27, 2026
Merged

chruffins merged 1 commit into
mainfrom
hypeship/escape-image-path-params

Conversation

@chruffins

@chruffins chruffins commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

summary

discovered this while testing

  • URL-escape image names used by GET and DELETE image endpoints
  • add regression coverage for repository names containing slashes

testing

  • ./scripts/test

Note

Low Risk
Localized client URL construction fix with regression tests; no auth or server behavior changes.

Overview
Fixes broken GET/DELETE for OCI image references that include slashes (e.g. docker.io/library/alpine:latest) by applying url.PathEscape when building the images/{name} path in ImageService.Delete and ImageService.Get.

Adds TestImagePathParameterEscapesRepositorySlashes, which stubs HTTP and asserts the escaped path is /images/docker.io%2Flibrary%2Falpine:latest for both operations.

Reviewed by Cursor Bugbot for commit f4bcdb4. Configure here.

@chruffins
chruffins requested a review from sjmiller609 August 27, 2026 20:01
@chruffins
chruffins marked this pull request as ready for review August 27, 2026 20:01
@chruffins
chruffins merged commit d300341 into main Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant