Repository navigation
Update Hypeman build toolchains to Go 1.26.10 - #525
Open
sjmiller609 wants to merge 1 commit into
Open
sjmiller609 wants to merge 1 commit into
sjmiller609 wants to merge 1 commit into
Conversation
sjmiller609
marked this pull request as ready for review
October 20, 2026 21:03
chruffins
reviewed
Oct 20, 2026
chruffins
left a comment
Contributor
There was a problem hiding this comment.
Bugs
scripts/utm/bootstrap-dev-environment.sh:52— the guardgrep -q "go1.2"matchesgo1.25.4, so machines that already have a 1.2x toolchain skip the install and never reach the newGO_VERSIONon line 55. compare the installed version againstGO_VERSIONbefore skipping. the guard predates this PR, but the bump is what it needs to deliver.
Questions
.github/actions/setup-stlc/action.yml:20—go-version: "stable"floats and is not pinned. is SDK generation meant to be in the 1.26.10 alignment scope? this line is not in the diff.
Structural / Maintainability
.github/workflows/test.yml:92— the same version is hand-written in ten places: six workflow pins,go.mod, the builder Dockerfile, the CloudFormation download, and the bootstrap script. this duplication predates the PR.vuln-remediation.yml:16already usesgo-version-file: 'go.mod', so the workflows could follow it. suggested as a follow-up, not a blocker.
Nits
DEVELOPMENT.md:9,:19,:371— still say "Go 1.25.4+". update them to 1.26.10+.
coverage — all 7 changed files inspected. repo-wide grep found no other executable 1.25 pins; remaining hits are test fixtures (golang:1.21, golang:1.22 examples) and unrelated text. go1.26.10 is present in the go.dev release index, and the Dockerfile and tarball names are correct. not verified: the CVE-2026-111943 mitigation claim, rebuilt Caddy/guest-agent/init binaries, macOS builds, full builder-image builds, cfn-lint.
status: review complete; read-only analysis; no tests run
chruffins
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go build -tags containers_image_openpgp ./....lib/ingress/...,lib/system/...anddeploy/aws/cloudformation.Rollout
Release/rebuild and deploy after merging, with the infrastructure toolchain/trust updates. No running hosts or services were changed.
Note
Low Risk
Version-pin-only change across CI, Docker, and bootstrap scripts; no runtime behavior changes until artifacts are rebuilt and redeployed.
Overview
Bumps the required Go toolchain from 1.25.4 to 1.26.10 everywhere Hypeman is built or bootstrapped, so local, CI, release, and infra installs stay on one compiler version (including the CVE-2026-111943 certificate-chain fix in this Go release).
go.modnow declaresgo 1.26.10. GitHub Actions indeploy.yml,release.yml, andtest.yml(Linux KVM, macOS test, and e2e jobs) all use that version viaactions/setup-go.deploy/aws/cloudformation/template.yamldownloadsgo1.26.10.linux-amd64when building from a branch on EC2. The generic builder imagelib/builds/images/generic/Dockerfileswitches the agent build stage fromgolang:1.25-alpinetogolang:1.26.10-alpine.scripts/utm/bootstrap-dev-environment.shpins the same version for arm64 dev VMs.There are no application or API logic changes in the diff—only version pins. Embedded binaries (Caddy, guest-agent, etc.) are expected to be rebuilt on the normal release path after merge.
Reviewed by Cursor Bugbot for commit 2c5391e. Bugbot is set up for automated code reviews on this repo. Configure here.