Skip to content

security: video_api fails closed without token / 영상 API 인증 강화 - #7

Open
khs0927 wants to merge 3 commits into
mainfrom
grokbot/video-api-auth
Open

khs0927 wants to merge 3 commits into
mainfrom
grokbot/video-api-auth

Conversation

@khs0927

@khs0927 khs0927 commented Oct 16, 2026

Copy link
Copy Markdown
Owner

요약 (Korean)

VIDEO_API_TOKEN 없으면 요청 거부(fail-closed), 상수시간 비교, CORS 기본값 localhost, FAL 키 없을 때 TypeError 수정. 테스트 23개 통과. /outputs 는 아직 토큰 없이 열려 있음(결정 필요). / Fail-closed auth; 23 tests pass; /outputs still public.

Changes (commits)

  • Fal nodes: don't crash with TypeError when FAL key is missing
  • video_api: fail closed without VIDEO_API_TOKEN, constant-time compare, localhost CORS default

Not tested / 테스트하지 못한 부분

No real ComfyUI render run. / 실제 렌더링 미검증.

Builds on / 기반 PR

None / 없음


Prepared by Grok Bot. Not merged; please review. / 검토 후 직접 머지해 주세요.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T17:21:46.892195Z b3b6bd9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant