Skip to content

fix: Pause status requests during SD uploads - #1575

Open
ellensp wants to merge 1 commit into
kliment:masterfrom
ellensp:pause-polling-during-upload
Open

ellensp wants to merge 1 commit into
kliment:masterfrom
ellensp:pause-polling-during-upload

Conversation

@ellensp

@ellensp ellensp commented Nov 4, 2026 •

Copy link
Copy Markdown

Description

While a file uploads to SD with M28, the status checker in Pronterface and pronsole keeps sending M105. Marlin rejects lines without a line number during an upload, so each one gets an error and a resend request, and no temperature:

Error:No Checksum with line number, Last Line: 162
Resend: 163

Adding a line number wouldn't help, because Marlin would write the M105 into the file.

This PR stops the periodic M105 and M27 while uploading, and they resume when the upload ends. Commands typed by the user are still sent.

Pronterface already tracks uploads in self.uploading. The pronsole upload command didn't set it, so it now does, on both the normal and the interrupted path.

The temperature display and graph don't update during an upload, which was already the case because no temperature replies came back.

Testing

Tested on an MKS TinyBee running Marlin bugfix-2.1.x at 250000 baud, uploading the first 15000 lines of a PrusaSlicer file through Pronterface's own upload path, with status monitoring on:

master This PR
Errors and resend requests during the upload 4 of each None
Upload time 94.9 s 94.7 s
File size on the card 448989 bytes 448989 bytes
First M105 after the upload 27.4 s 3.4 s

The pronsole upload command, on the same board with the first 9000 lines of the file:

master This PR This PR, interrupted with Ctrl-C after 20 s
Errors and resend requests during the upload 2 of each None None
Upload time 56.3 s 57.3 s Stopped at 20.2 s
File size on the card 270550 bytes 270550 bytes 97380 bytes (partial)
Temperature replies after the upload Yes Yes Yes

All tests in tests/ pass.

AI disclosure

Full disclosure: I don't know your policy on AI, so please treat this PR accordingly.

AI used: Claude Opus 5.5 (Anthropic), via Claude Code. It wrote the code and this description, and ran the tests above on @ellensp's board. @ellensp found the problem, directed the work and verified the result.

While uploading with M28, Marlin rejects any line without a line number,
so each periodic M105 got "Error:No Checksum" and a "Resend" and never
returned a temperature. A numbered M105 would be written to the file
instead, so the requests can't work until the upload ends.

Stop sending M105 and M27 while uploading, and resume afterwards. The
pronsole upload command now sets the uploading flag that Pronterface
already uses.
@ellensp
ellensp force-pushed the pause-polling-during-upload branch from 98e35cc to 23d10d3 Compare November 4, 2026 23:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant