Repository navigation
Conversation
While uploading with M28, Marlin rejects any line without a line number, so each periodic M105 got "Error:No Checksum" and a "Resend" and never returned a temperature. A numbered M105 would be written to the file instead, so the requests can't work until the upload ends. Stop sending M105 and M27 while uploading, and resume afterwards. The pronsole upload command now sets the uploading flag that Pronterface already uses.
ellensp
force-pushed
the
pause-polling-during-upload
branch
from
November 4, 2026 23:06
98e35cc to
23d10d3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While a file uploads to SD with
M28, the status checker in Pronterface and pronsole keeps sendingM105. Marlin rejects lines without a line number during an upload, so each one gets an error and a resend request, and no temperature:Adding a line number wouldn't help, because Marlin would write the
M105into the file.This PR stops the periodic
M105andM27while uploading, and they resume when the upload ends. Commands typed by the user are still sent.Pronterface already tracks uploads in
self.uploading. The pronsoleuploadcommand didn't set it, so it now does, on both the normal and the interrupted path.The temperature display and graph don't update during an upload, which was already the case because no temperature replies came back.
Testing
Tested on an MKS TinyBee running Marlin
bugfix-2.1.xat 250000 baud, uploading the first 15000 lines of a PrusaSlicer file through Pronterface's own upload path, with status monitoring on:masterM105after the uploadThe pronsole
uploadcommand, on the same board with the first 9000 lines of the file:masterAll tests in
tests/pass.AI disclosure
Full disclosure: I don't know your policy on AI, so please treat this PR accordingly.
AI used: Claude Opus 5.5 (Anthropic), via Claude Code. It wrote the code and this description, and ran the tests above on @ellensp's board. @ellensp found the problem, directed the work and verified the result.