Repository navigation
Conversation
Lines uploaded to SD are stored, not run, but Pronterface treated them as if the printer were running them. Each M106 or M107 changed the fan on the temperature graph, and M104, M109, M140, M190 and T lines would change the targets and the tool selector in the same way. Skip these updates while uploading.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While a file uploads to SD, Pronterface's
sentcbtreats each sent line as if the printer were running it. Lines being uploaded are only stored on the card, but eachM106orM107changes the fan on the temperature graph.M104,M109,M140,M190andTlines go through the same code, for the targets and the tool selector.This PR skips those updates while
self.uploadingis set. Commands sent outside an upload update the displays as before.Testing
Tested on an MKS TinyBee running Marlin
bugfix-2.1.xat 250000 baud, uploading the first 9000 lines of a PrusaSlicer file, which include 84M106andM107lines, through Pronterface's own upload path:masterM106 S128thenM107after the uploadCalling
sentcbdirectly withM104andM140lines also updates the graph targets normally, and doesn't while uploading. All tests intests/pass.AI disclosure
Full disclosure: I don't know your policy on AI, so please treat this PR accordingly.
AI used: Claude Opus 5.5 (Anthropic), via Claude Code. It wrote the code and this description, and ran the tests above on @ellensp's board. @ellensp found the problem, directed the work and verified the result.