fix(gateway): normalize status hostname to lowercase (#4591)

Author: TOGEP

controllers/gateway/gateway_controller.go

@@ -3,6 +3,7 @@ package gateway
 import (
 	"context"
 	"fmt"
+	"strings"
 	"time"
 
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/certs"
@@ -415,13 +416,14 @@ func (r *gatewayReconciler) updateGatewayStatusSuccess(ctx context.Context, lbSt
 	}
 
 	needPatch = r.gatewayConditionUpdater(gw, string(gwv1.GatewayConditionAccepted), metav1.ConditionTrue, string(gwv1.GatewayConditionAccepted), "") || needPatch
+	normalizedDNSName := strings.ToLower(lbStatus.DNSName)
 	if len(gw.Status.Addresses) != 1 ||
-		gw.Status.Addresses[0].Value != lbStatus.DNSName {
+		gw.Status.Addresses[0].Value != normalizedDNSName {
 		ipAddressType := gwv1.HostnameAddressType
 		gw.Status.Addresses = []gwv1.GatewayStatusAddress{
 			{
 				Type:  &ipAddressType,
-				Value: lbStatus.DNSName,
+				Value: normalizedDNSName,
 			},
 		}
 		needPatch = true

controllers/gateway/gateway_controller_test.go

@@ -6,13 +6,16 @@ import (
 	"testing"
 	"time"
 
+	elbv2types "github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2/types"
 	"github.com/go-logr/logr"
 	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/tools/record"
 	ctrlerrors "sigs.k8s.io/aws-load-balancer-controller/pkg/error"
 	gateway_constants "sigs.k8s.io/aws-load-balancer-controller/pkg/gateway/constants"
+	"sigs.k8s.io/aws-load-balancer-controller/pkg/gateway/routeutils"
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/k8s"
+	elbv2model "sigs.k8s.io/aws-load-balancer-controller/pkg/model/elbv2"
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/testutils"
 	gwv1 "sigs.k8s.io/gateway-api/apis/v1"
 )
@@ -140,3 +143,41 @@ func Test_handleReconcileError(t *testing.T) {
 		})
 	}
 }
+
+func Test_updateGatewayStatusSuccess_normalizesDNSNameToLowercase(t *testing.T) {
+	k8sClient := testutils.GenerateTestClient()
+	gw := &gwv1.Gateway{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "test-gw",
+			Namespace: "test-ns",
+		},
+	}
+	err := k8sClient.Create(context.Background(), gw)
+	assert.NoError(t, err)
+
+	reconciler := &gatewayReconciler{
+		k8sClient:               k8sClient,
+		logger:                  logr.Discard(),
+		eventRecorder:           record.NewFakeRecorder(10),
+		gatewayConditionUpdater: prepareGatewayConditionUpdate,
+	}
+
+	lbStatus := &elbv2model.LoadBalancerStatus{
+		LoadBalancerARN: "arn:aws:elasticloadbalancing:region:account-id:loadbalancer/app/my-alb/123456789",
+		DNSName:         "MyCamelBalancer-1234567890.EU-WEST-1.ELB.AMAZONAWS.COM",
+		ProvisioningState: &elbv2types.LoadBalancerState{
+			Code: elbv2types.LoadBalancerStateEnumActive,
+		},
+	}
+
+	err = reconciler.updateGatewayStatusSuccess(context.Background(), lbStatus, gw, routeutils.LoaderResult{})
+	assert.NoError(t, err)
+
+	updatedGW := &gwv1.Gateway{}
+	err = k8sClient.Get(context.Background(), k8s.NamespacedName(gw), updatedGW)
+	assert.NoError(t, err)
+	assert.Len(t, updatedGW.Status.Addresses, 1)
+	assert.Equal(t, "mycamelbalancer-1234567890.eu-west-1.elb.amazonaws.com", updatedGW.Status.Addresses[0].Value)
+	assert.NotNil(t, updatedGW.Status.Addresses[0].Type)
+	assert.Equal(t, gwv1.HostnameAddressType, *updatedGW.Status.Addresses[0].Type)
+}