Auto discovery default certificate and certificate list#4490
Auto discovery default certificate and certificate list#4490abeowlu wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
|
|
Welcome @abeowlu! |
|
Hi @abeowlu. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test Seems good to me. We'll include this in our first release of the new year. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
0320065 to
78fc6a7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abeowlu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
@zac-nixon , looks like flakiness in the test? failing on a security group deletion dependency |
779825a to
1741147
Compare
|
@abeowlu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
#4090
Description
AWS ELB API ignores the default certificate when certificate list is provided in TLS negotiation.
The auto discovered default certificate is needed for TLS negotiation. Adding the default certificate discovered to the extre certificate list
brief logic change:
certificate-arnimplements similar functionality, and that logic shortcircuits auto-discovery executionChecklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯