🌱 Replace static sleep with active polling for IAM access key propagation#5862
🌱 Replace static sleep with active polling for IAM access key propagation#5862Arpit529Srivastava wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
|
Hi @Arpit529Srivastava. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ricardoapl @nrb PTAL when u get time and let me know if you need any changes or modification. |
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
|
@AndiDog does this need a release note? It's just an update to a test function. I don't think one is needed. |
Edited 👍 |
|
Looks good. Let's squash so we can merge the PR. /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 8f4e95f7fc87debdfc546306715d88dfbb97124d |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change replaces a hard-coded 10-second sleep with active polling using
sts:GetCallerIdentityto verify iam access key propagation. this avoids intermittent e2e test failures caused by aws iam eventual consistency.Which issue(s) this PR fixes:
Fixes #5551
Special notes for your reviewer:
Checklist:
Release note: