Skip to content

🌱 Replace static sleep with active polling for IAM access key propagation#5862

Open
Arpit529Srivastava wants to merge 2 commits intokubernetes-sigs:mainfrom
Arpit529Srivastava:fix-e2e-access-key-propagation
Open

🌱 Replace static sleep with active polling for IAM access key propagation#5862
Arpit529Srivastava wants to merge 2 commits intokubernetes-sigs:mainfrom
Arpit529Srivastava:fix-e2e-access-key-propagation

Conversation

@Arpit529Srivastava
Copy link
Copy Markdown
Contributor

@Arpit529Srivastava Arpit529Srivastava commented Feb 8, 2026

What type of PR is this?
/kind bug

What this PR does / why we need it:
This change replaces a hard-coded 10-second sleep with active polling using sts:GetCallerIdentity to verify iam access key propagation. this avoids intermittent e2e test failures caused by aws iam eventual consistency.

Which issue(s) this PR fixes:
Fixes #5551

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Arpit529Srivastava. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Arpit529Srivastava
Copy link
Copy Markdown
Contributor Author

@ricardoapl @nrb PTAL when u get time and let me know if you need any changes or modification.
thanks :)

Copy link
Copy Markdown
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Comment thread test/e2e/shared/aws.go Outdated
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2026
Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>
@faiq
Copy link
Copy Markdown
Contributor

faiq commented Feb 9, 2026

@AndiDog does this need a release note? It's just an update to a test function. I don't think one is needed.

@Arpit529Srivastava
Copy link
Copy Markdown
Contributor Author

@AndiDog does this need a release note? It's just an update to a test function. I don't think one is needed.

Edited 👍

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 11, 2026
@AndiDog
Copy link
Copy Markdown
Contributor

AndiDog commented Mar 9, 2026

Looks good. Let's squash so we can merge the PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 8f4e95f7fc87debdfc546306715d88dfbb97124d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[E2E] Some tests failing with security token invalid

4 participants